linux-kernel - Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240125-kindness-remnant-1a43ff5c2ba7@spud>
Date: Thu, 25 Jan 2024 17:19:25 +0000
From: Conor Dooley <conor@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
	git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
	Krishna Potthuri <sai.krishna.potthuri@....com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string

On Thu, Jan 25, 2024 at 08:06:35AM +0100, Michal Simek wrote:
> 
> 
> On 1/24/24 17:16, Conor Dooley wrote:
> > On Wed, Jan 24, 2024 at 10:07:46AM +0100, Michal Simek wrote:
> > > Compatible string doesn't really match with compatible string listed in the
> > > driver itself. While binding was converted from txt to yaml
> > > xlnx,zynq-pinctrl was listed as compatible string but example was using
> > > xlnx,pinctrl-zynq and also this string is used in all DTSes.
> > > xlnx,zynq-pinctrl is used only in dt binding and not present in any DT
> > > which is stable for quite a long time that's why use old compatible string
> > > and update binding document instead of starting to use unused compatible
> > > string.
> > > 
> > > Fixes: 153df45acda0 ("dt-bindings: pinctrl: pinctrl-zynq: Convert to yaml")
> > > Signed-off-by: Michal Simek <michal.simek@....com>
> > 
> > I assume that U-Boot etc all use the "incorrect" compatible as was in
> > the example? If they do, then the patch seems good to me.
> 
> Yes. U-Boot is using "incorrect" compatible string from 2015.

Okay. Assuming U-Boot is the only other user, it eems reasonable to
document the defacto compatible then.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)