linux-kernel - Re: [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 00:12:26 -0800
From: Prashant Malani <pmalani@...omium.org>
To: Abhishek Pandit-Subedi <abhishekpandit@...gle.com>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-usb@...r.kernel.org, 
	jthies@...gle.com, Abhishek Pandit-Subedi <abhishekpandit@...omium.org>, 
	Bjorn Andersson <andersson@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hans de Goede <hdegoede@...hat.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Saranya Gopal <saranya.gopal@...el.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] usb: typec: ucsi: Limit read size on v1.2

Hi Abhishek,

On Tue, Jan 23, 2024 at 2:30 PM Abhishek Pandit-Subedi
<abhishekpandit@...gle.com> wrote:
>
> From: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
>
> Between UCSI 1.2 and UCSI 2.0, the size of the MESSAGE_IN region was
> increased from 16 to 256. In order to avoid overflowing reads for older
> systems, add a mechanism to use the read UCSI version to truncate read
> sizes on UCSI v1.2.
>
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
I have one nit (mentioned in side-band but reproducing here for consistency),
but will defer to the maintainer on that.

The above notwithstanding, FWIW:
Reviewed-by: Prashant Malani<pmalani@...omium.org>

> @@ -1556,6 +1569,15 @@ int ucsi_register(struct ucsi *ucsi)
>         if (!ucsi->version)
>                 return -ENODEV;
>
> +       /*
> +        * Version format is JJ.M.N (JJ = Major version, M = Minor version,
> +        * N = sub-minor version).
> +        */
> +       dev_info(ucsi->dev, "Registered UCSI interface with version %x.%x%x",
> +                UCSI_BCD_GET_MAJOR(ucsi->version),
> +                UCSI_BCD_GET_MINOR(ucsi->version),
> +                UCSI_BCD_GET_SUBMINOR(ucsi->version));

nit: I think this doesn't need to be dev_info() and can be just
dev_dbg(), but will
defer to the maintainer.

Thanks,

-Prashant