linux-kernel - Re: [PATCH v1 0/3] usb: typec: ucsi: Adding support for UCSI 3.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8ec55a3-967f-40dc-9008-b4f5061023e4@linaro.org>
Date: Wed, 24 Jan 2024 13:44:03 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Abhishek Pandit-Subedi <abhishekpandit@...gle.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-usb@...r.kernel.org
Cc: pmalani@...omium.org, jthies@...gle.com,
 Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hans de Goede <hdegoede@...hat.com>, Saranya Gopal
 <saranya.gopal@...el.com>, linux-kernel@...r.kernel.org,
 linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v1 0/3] usb: typec: ucsi: Adding support for UCSI 3.0

On 23/01/2024 23:30, Abhishek Pandit-Subedi wrote:
> From: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> 
> 
> Hi Heikki,
> 
> This series starts the work adding UCSI 3.0 support to the UCSI driver.
> 
> There's a couple of pieces to start here:
> * Add version checks and limit read size on 1.2.
> * Update Connector Status and Connector Capability structures.
> * Expose Partner PD revision from Capability data.
> 
> These were tested against on a 6.6 kernel running a usermode PPM against
> a Realtek Evaluation board.
> 
> One additional note: there are a lot more unaligned fields in UCSI now
> and the struct definitions are getting a bit out of hand. We can discuss
> alternate mechanisms for defining these structs in the patch that
> changes these structures.
> 
> Thanks,
> Abhishek
> 
> 
> Abhishek Pandit-Subedi (3):
>    usb: typec: ucsi: Limit read size on v1.2
>    usb: typec: ucsi: Update connector cap and status
>    usb: typec: ucsi: Get PD revision for partner
> 
>   drivers/usb/typec/ucsi/ucsi.c | 51 ++++++++++++++++++++++++++--
>   drivers/usb/typec/ucsi/ucsi.h | 64 ++++++++++++++++++++++++++++++++---
>   2 files changed, 109 insertions(+), 6 deletions(-)
> 

[    7.417925] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: Registered UCSI interface with version 1.1.0

Tested-by: Neil Armstrong <neil.armstrong@...aro.org> # on SM8650-QRD

[    9.085733] ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: Registered UCSI interface with version 1.1.0

Tested-by: Neil Armstrong <neil.armstrong@...aro.org> # on SM8550-QRD

Thanks,
Neil