linux-kernel - Re: [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbKFzGxXhU0TABHZ@kekkonen.localdomain>
Date: Thu, 25 Jan 2024 16:01:16 +0000
From: "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
To: Zhi Mao (毛智) <zhi.mao@...iatek.com>
Cc: "heiko@...ech.de" <heiko@...ech.de>,
	"gerald.loacker@...fvision.net" <gerald.loacker@...fvision.net>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"yunkec@...omium.org" <yunkec@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dan.scally@...asonboard.com" <dan.scally@...asonboard.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	Shengnan Wang (王圣男) <shengnan.wang@...iatek.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
	Yaya Chang (張雅清) <Yaya.Chang@...iatek.com>,
	"mchehab@...nel.org" <mchehab@...nel.org>,
	"jacopo.mondi@...asonboard.com" <jacopo.mondi@...asonboard.com>,
	"jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"bingbu.cao@...el.com" <bingbu.cao@...el.com>,
	Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"10572168@...com" <10572168@...com>,
	"hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"tomi.valkeinen@...asonboard.com" <tomi.valkeinen@...asonboard.com>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com>,
	"macromorgan@...mail.com" <macromorgan@...mail.com>
Subject: Re: [PATCH v3 2/2] media: i2c: Add GC08A3 image sensor driver

Hi Zhi,

On Thu, Jan 25, 2024 at 02:24:52AM +0000, Zhi Mao (毛智) wrote:
> Hi Sakari
> 
> Thanks for your review code and comments.
> 
> On Tue, 2024-01-09 at 10:18 +0000, Sakari Ailus wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  Hi Zhi,
> > 
> > Thanks for the update.
> > 
> > On Tue, Jan 09, 2024 at 10:27:15AM +0800, Zhi Mao wrote:
> > > Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor.
> > > 
> > > Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>
> > > ---
> > >  drivers/media/i2c/Kconfig  |   10 +
> > >  drivers/media/i2c/Makefile |    1 +
> > >  drivers/media/i2c/gc08a3.c | 1467
> > ++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 1478 insertions(+)
> > >  create mode 100644 drivers/media/i2c/gc08a3.c
> > > 
> > > +for (i = 0; i < ARRAY_SIZE(link_freq_menu_items); i++) {
> > > +for (j = 0; j < bus_cfg.nr_of_link_frequencies; j++) {
> > > +if (link_freq_menu_items[i] ==
> > > +    bus_cfg.link_frequencies[j])
> > > +break;
> > > +}
> > > +
> > > +if (j == bus_cfg.nr_of_link_frequencies) {
> > > +dev_err(dev,
> > > +"no link frequency %lld supported, please check DT",
> > > +link_freq_menu_items[i]);
> > > +ret = -EINVAL;
> > > +goto done;
> > > +}
> > > +}
> > 
> > Please use v4l2_link_freq_to_bitmap() available here
> > <URL:
> > https://lore.kernel.org/linux-media/20240108151805.55584-2-sakari.ailus@linux.intel.com/T/#u>
> > ;.
> > We'll then merge both at the same time.
> > 
> 
> After got the latest linux kernel code base(tag: next-20240124), there
> seems to be not new API:v4l2_link_freq_to_bitmap() still.
> 
> Would you please let me know, how about the status about this API?

The patches are in my linuxtv.org tree's master branch now:

	https://git.linuxtv.org/sailus/media_tree.git/

-- 
Sakari Ailus