[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1abe92bbe6e93f119a735e41dfdc0eac7f0a5080.camel@mediatek.com>
Date: Sun, 4 Feb 2024 06:34:41 +0000
From: Zhi Mao (毛智) <zhi.mao@...iatek.com>
To: "mchehab@...nel.org" <mchehab@...nel.org>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>
CC: "heiko@...ech.de" <heiko@...ech.de>, "gerald.loacker@...fvision.net"
<gerald.loacker@...fvision.net>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "yunkec@...omium.org" <yunkec@...omium.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"dan.scally@...asonboard.com" <dan.scally@...asonboard.com>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Shengnan Wang (王圣男)
<shengnan.wang@...iatek.com>, "hdegoede@...hat.com" <hdegoede@...hat.com>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
Yaya Chang (張雅清) <Yaya.Chang@...iatek.com>,
"bingbu.cao@...el.com" <bingbu.cao@...el.com>,
"jacopo.mondi@...asonboard.com" <jacopo.mondi@...asonboard.com>,
"jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>, "10572168@...com"
<10572168@...com>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
"tomi.valkeinen@...asonboard.com" <tomi.valkeinen@...asonboard.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "laurent.pinchart@...asonboard.com"
<laurent.pinchart@...asonboard.com>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>, "macromorgan@...mail.com"
<macromorgan@...mail.com>
Subject: Re: [PATCH v3 1/2] media: dt-bindings: media: i2c: Document GC08A3
bindings
Hi Krzysztof,
Thanks for your review.
On Tue, 2024-01-09 at 10:24 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 09/01/2024 03:27, Zhi Mao wrote:
> > Add YAML device tree binding for GC08A3 CMOS image sensor,
> > and the relevant MAINTAINERS entries.
> >
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
>
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Subject: only one "media", so:
> media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor
>
fixed in patch:v4.
> > Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>
>
> ...
>
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sensor0@31 {
>
> sensor@31
>
> With above fixed:
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
fixed in patch:v4.
> Before you reply, fix your email client. It's impossible to read your
> responses.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists