linux-kernel - Re: [PATCH v2 21/28] spi: s3c64xx: infer fifosize from the compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2086b88e-45fc-4224-b00f-0840d446d042@sirena.org.uk>
Date: Thu, 25 Jan 2024 17:18:01 +0000
From: Mark Brown <broonie@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: andi.shyti@...nel.org, arnd@...db.de, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	alim.akhtar@...sung.com, linux-spi@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-arch@...r.kernel.org, andre.draszik@...aro.org,
	peter.griffin@...aro.org, semen.protsenko@...aro.org,
	kernel-team@...roid.com, willmcvicker@...gle.com
Subject: Re: [PATCH v2 21/28] spi: s3c64xx: infer fifosize from the compatible

On Thu, Jan 25, 2024 at 02:49:59PM +0000, Tudor Ambarus wrote:

> Infer the FIFO size from the compatible, where all the instances of the
> SPI IP have the same FIFO size. This way we no longer depend on the SPI
> alias from the device tree to select the FIFO size, thus we remove the
> dependency of the driver on the SPI alias.

>  static const struct s3c64xx_spi_port_config s3c2443_spi_port_config = {
> -	.fifo_lvl_mask	= { 0x7f },
> +	.fifosize	= 64,
>  	.rx_lvl_offset	= 13,
>  	.tx_st_done	= 21,
>  	.clk_div	= 2,

I'm having real trouble associating the changelog with the change here.
This appears to be changing from specifying the mask for the FIFO level
register to specifying the size of the FIFO and unrelated to anything to
do with looking things up from the compatible?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)