linux-kernel - Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5b0e7bd-25e5-49a4-8ac2-349020c2344b@linux.ibm.com>
Date: Thu, 25 Jan 2024 15:23:56 -0600
From: Ninad Palsule <ninad@...ux.ibm.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        joel@....id.au, andrew@...econstruct.com.au, peterhuewe@....de,
        jarkko@...nel.org, jgg@...pe.ca, keescook@...omium.org,
        tony.luck@...el.com, gpiccoli@...lia.com,
        johannes.holland@...ineon.com, linux@...ck-us.net, broonie@...nel.org,
        andre.werner@...tec-electronic.com,
        Andrew Geissler <geissonator@...oo.com>, patrick.rudolph@...ements.com,
        vincent@...emblay.dev, peteryin.openbmc@...il.com, lakshmiy@...ibm.com,
        bhelgaas@...gle.com, naresh.solanki@...ements.com,
        alexander.stein@...tq-group.com, festevam@...x.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-hardening@...r.kernel.org,
        geert+renesas@...der.be, luca.ceresoli@...tlin.com
Subject: Re: [PATCH v4 3/3] ARM: dts: aspeed: System1: IBM system1 BMC board

Hello Bjorn,

On 1/16/24 13:03, Bjorn Helgaas wrote:
> On Tue, Jan 16, 2024 at 12:37:34PM -0600, Ninad Palsule wrote:
>> From: Andrew Geissler <geissonator@...oo.com>
>>
>> Add a device tree for IBM system1 BMC board. It uses AST2600 SOC.
>> - Added base board
> s/Added/Add/ to match first sentence.
Fixed
>
>> - Added i2c devices and muxes.
>> - Added different voltage regulators.
>> - Added GPIO pin assignements, GPIO expansion devices
>> - Added LED brinker devices
> "brinker"?  "blinker" maybe (no idea what it actually is).
Fixed. Its blinker.
>> - Added Fan controllers
> s/Fan/fan/
Fixed.
>
>> - Added EEPROM/VPD
>> - Added Power supplies
> s/Power/power/
Fixed.
>
>> - Added Humidity, pressure and temperature sensors.
> s/Humidity/humidity/
Fixed.
>
>> - Added Trusted platform module(TPM) chip.
> s/Trusted platform module/Trusted Platform Module /
Fixed
>
>> Tested:
>>      This board is tested using the simics simulator.
>>
>> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
>> Signed-off-by: Andrew Geissler <geissonator@...oo.com>
> Your sign-off should be last since you are sending the series.

Fixed.

Thanks for the review.

Regards,

Ninad Palsule