linux-kernel - Re: [PATCH v2 21/28] spi: s3c64xx: infer fifosize from the compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPLW+4mG_xVvZRrE_jfMxK2zO9GnLAPrHPdzW5bCOPpoiuCjsA@mail.gmail.com>
Date: Thu, 25 Jan 2024 16:28:22 -0600
From: Sam Protsenko <semen.protsenko@...aro.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: broonie@...nel.org, andi.shyti@...nel.org, arnd@...db.de, 
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	alim.akhtar@...sung.com, linux-spi@...r.kernel.org, 
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-arch@...r.kernel.org, andre.draszik@...aro.org, 
	peter.griffin@...aro.org, kernel-team@...roid.com, willmcvicker@...gle.com
Subject: Re: [PATCH v2 21/28] spi: s3c64xx: infer fifosize from the compatible

On Thu, Jan 25, 2024 at 8:50 AM Tudor Ambarus <tudor.ambarus@...aroorg> wrote:
>
> Infer the FIFO size from the compatible, where all the instances of the
> SPI IP have the same FIFO size. This way we no longer depend on the SPI
> alias from the device tree to select the FIFO size, thus we remove the
> dependency of the driver on the SPI alias.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
>  drivers/spi/spi-s3c64xx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 5a93ed4125b0..b86eb0a77b60 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1381,7 +1381,7 @@ static const struct dev_pm_ops s3c64xx_spi_pm = {
>  };
>
>  static const struct s3c64xx_spi_port_config s3c2443_spi_port_config = {
> -       .fifo_lvl_mask  = { 0x7f },

How will it work with already existing out-of-tree dts's, if only
kernel image gets updated? I wonder if it's considered ok to break
that compatibility like this.

> +       .fifosize       = 64,
>         .rx_lvl_offset  = 13,
>         .tx_st_done     = 21,
>         .clk_div        = 2,
> @@ -1389,7 +1389,7 @@ static const struct s3c64xx_spi_port_config s3c2443_spi_port_config = {
>  };
>
>  static const struct s3c64xx_spi_port_config s3c6410_spi_port_config = {
> -       .fifo_lvl_mask  = { 0x7f, 0x7F },
> +       .fifosize       = 64,
>         .rx_lvl_offset  = 13,
>         .tx_st_done     = 21,
>         .clk_div        = 2,
> @@ -1435,7 +1435,7 @@ static const struct s3c64xx_spi_port_config exynos5433_spi_port_config = {
>  };
>
>  static const struct s3c64xx_spi_port_config exynos850_spi_port_config = {
> -       .fifo_lvl_mask  = { 0x7f, 0x7f, 0x7f },
> +       .fifosize       = 64,
>         .rx_lvl_offset  = 15,
>         .tx_st_done     = 25,
>         .clk_div        = 4,
> @@ -1459,7 +1459,7 @@ static const struct s3c64xx_spi_port_config exynosautov9_spi_port_config = {
>  };
>
>  static const struct s3c64xx_spi_port_config fsd_spi_port_config = {
> -       .fifo_lvl_mask  = { 0x7f, 0x7f, 0x7f, 0x7f, 0x7f},
> +       .fifosize       = 64,
>         .rx_lvl_offset  = 15,
>         .tx_st_done     = 25,
>         .clk_div        = 2,
> --
> 2.43.0.429.g432eaa2c6b-goog
>