linux-kernel - Re: [PATCH 09/15] tick: Move broadcast cancellation up to CPUHP_AP_TICK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttn1iwgz.ffs@tglx>
Date: Thu, 25 Jan 2024 10:38:36 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Frederic Weisbecker <frederic@...nel.org>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>, Ingo Molnar
 <mingo@...nel.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>, Peng
 Liu <liupeng17@...ovo.com>, Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH 09/15] tick: Move broadcast cancellation up to
 CPUHP_AP_TICK_DYING

On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> The broadcast shutdown code is executed through a random explicit call
> within stop machine from the outgoing CPU.
>
> However The tick broadcast is a midware between the tick callback and

s/The/the/

> the clocksource, therefore it makes more sense to shut it down after the
> tick callback and before the clocksource drivers.
>
> Move it instead to the common tick shutdown CPU hotplug state where
> related operations can be ordered from highest to lowest level.
>
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>