linux-kernel - Re: [PATCH 10/15] tick: Assume the tick can't be stopped in NOHZ_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0i5iwfj.ffs@tglx>
Date: Thu, 25 Jan 2024 10:39:28 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Frederic Weisbecker <frederic@...nel.org>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>, Ingo Molnar
 <mingo@...nel.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>, Peng
 Liu <liupeng17@...ovo.com>, Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH 10/15] tick: Assume the tick can't be stopped in
 NOHZ_MODE_INACTIVE mode

On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> The full-nohz update function checks if the nohz mode is active before
> proceeding. It considers one exception though: if the tick is already
> stopped even though the nohz mode is inactive, it still moves on in
> order to update/restart the tick if needed.
>
> However in order for the tick to be stopped, the nohz_mode has to be
> either NOHZ_MODE_LOWRES or NOHZ_MODE_HIGHRES. Therefore it doesn't make
> sense to test if the tick is stopped before verifying NOHZ_MODE_INACTIVE
> mode.
>
> Remove the needless related condition.
>
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>