linux-kernel - Re: [PATCH v2 2/4] reset: sophgo: add SG2042 reset generator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB28226D07A5DC0200132358C4FE7A2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 25 Jan 2024 20:07:43 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Philipp Zabel <p.zabel@...gutronix.de>, Chen Wang <unicornxw@...il.com>,
 aou@...s.berkeley.edu, chao.wei@...hgo.com, conor@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, palmer@...belt.com,
 paul.walmsley@...ive.com, robh+dt@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, guoren@...nel.org,
 jszhang@...nel.org, inochiama@...look.com
Subject: Re: [PATCH v2 2/4] reset: sophgo: add SG2042 reset generator driver


On 2024/1/25 18:43, Philipp Zabel wrote:
> On Do, 2024-01-25 at 14:11 +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@...look.com>
>>
>> Reuse reset-simple driver for the Sophgo SG2042 reset generator.
> Subject prefix should be "reset: simple: "
Ok.
>
>> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
>> ---
>>   drivers/reset/Kconfig        |  1 +
>>   drivers/reset/reset-simple.c |  2 ++
>>   drivers/reset/sophgo/Kconfig | 10 ++++++++++
>>   3 files changed, 13 insertions(+)
>>   create mode 100644 drivers/reset/sophgo/Kconfig
>>
> [...]
>> diff --git a/drivers/reset/sophgo/Kconfig b/drivers/reset/sophgo/Kconfig
>> new file mode 100644
>> index 000000000000..9ad96e49e1dd
>> --- /dev/null
>> +++ b/drivers/reset/sophgo/Kconfig
>> @@ -0,0 +1,10 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +
>> +config RESET_SOPHGO_SG2042
>> +	bool "Sophgo SG2042 Reset Driver"
>> +	depends on ARCH_SOPHGO || COMPILE_TEST
>> +	select RESET_SIMPLE
>> +	default ARCH_SOPHGO
>> +	help
>> +	  This enables the reset controller driver for the Sophgo SG2042 SoC.
>> +
> Drop the Kconfig, just add a default y if ARCH_SOPHGO to RESET_SIMPLE.

hi，Philipp,

The purpose of my adding Kconfig is to consider that other socs under 
sophgo may not use RESET_SIMPLE. I'm worried that the coverage is too 
large when default y if ARCH_SOPHGO? What do you think?

Thanks,

Chen

>
> regards
> Philipp