linux-kernel - Re: [PATCH v2 2/5] arm64: dts: ti: k3-j784s4: Add Main CPSW2G node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240125134411.nzw7mou7cth7hh4m@postage>
Date: Thu, 25 Jan 2024 07:44:11 -0600
From: Nishanth Menon <nm@...com>
To: Chintan Vankar <c-vankar@...com>
CC: Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, Tero
 Kristo <kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <afd@...com>, <srk@...com>, <s-vadapalli@...com>,
        <r-gunasekaran@...com>, <danishanwar@...com>, <tony@...mide.com>,
        Jayesh Choudhary <j-choudhary@...com>
Subject: Re: [PATCH v2 2/5] arm64: dts: ti: k3-j784s4: Add Main CPSW2G node

On 15:02-20240125, Chintan Vankar wrote:
> 
> On 19/01/24 18:48, Nishanth Menon wrote:
> > On 15:14-20240118, Chintan Vankar wrote:
> > > From: Siddharth Vadapalli<s-vadapalli@...com>
> > > 
> > > J784S4 SoC has a Main CPSW2G instance of the CPSW Ethernet Switch.
> > > 
> > > Add the device-tree nodes for the Main CPSW2G instance and enable it.
> > > 
> > > Signed-off-by: Siddharth Vadapalli<s-vadapalli@...com>
> > > Signed-off-by: Jayesh Choudhary<j-choudhary@...com>
> > > Signed-off-by: Chintan Vankar<c-vankar@...com>
> > > ---
> > >   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts   | 47 +++++++++++++++
> > >   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 68 ++++++++++++++++++++++
> > >   2 files changed, 115 insertions(+)
> > Please do not mix the SoC and evm changes in the same patch.
> Okay. I will separate them in the v3 series
> > Also, any benefits of giving the second instance an alias?
> 
> Yes, there are benefits of adding an alias,
> 
> I will add aliases for both Main and MCU cpsw2g,
> 
> and post it in a future series.

If there is benefit, squash to current patch.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D