linux-kernel - Re: [PATCH 1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170619067236.1476369.7542248214179652574.b4-ty@kernel.org>
Date: Thu, 25 Jan 2024 13:51:12 +0000
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
 Arnd Bergmann <arnd@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Arnd Bergmann <arnd@...db.de>, 
 Heiner Kallweit <hkallweit1@...il.com>, Hans de Goede <hdegoede@...hat.com>, 
 Jean-Jacques Hiblot <jjhiblot@...phandler.com>, linux-leds@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] leds: remove led_init_default_state_get() and
 devm_led_classdev_register_ext() stubs

On Tue, 09 Jan 2024 10:06:39 +0100, Arnd Bergmann wrote:
> These two functions have stub implementations that are called when
> NEW_LEDS and/or LEDS_CLASS are disabled, theorerically allowing drivers
> to optionally use the LED subsystem.
> 
> However, this has never really worked because a built-in driver is
> unable to link against these functions if the LED class is in a loadable
> module. Heiner ran into this problem with a driver that newly gained
> a LEDS_CLASS dependency and suggested using an IS_REACHABLE() check.
> 
> [...]

Applied, thanks!

[1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs
      commit: c0b64609dada48907b04b48873ba052efa8f121d
[2/2] leds: make flash and multicolor dependencies unconditional
      commit: 54602f38551e89b520611ffb9df05232d1bf73f8

--
Lee Jones [李琼斯]