linux-kernel - Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240125135509.GL74950@google.com>
Date: Thu, 25 Jan 2024 13:55:09 +0000
From: Lee Jones <lee@...nel.org>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc: broonie@...nel.org, andy.shevchenko@...il.com,
	patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

On Thu, 25 Jan 2024, Charles Keepax wrote:

> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>

Patches look okay to me, but seeing as Andy suggested the changes, it
would be good to get a R-by from him.

> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> ---
> 
> Changes since v2:
>  - Added pm.h and regmap.h back into mfd/cs42l43.h
> 
> Thanks,
> Charles
> 
>  drivers/mfd/cs42l43-i2c.c   |  6 +++++-
>  drivers/mfd/cs42l43-sdw.c   |  6 +++++-
>  drivers/mfd/cs42l43.c       |  8 +++++++-
>  drivers/mfd/cs42l43.h       | 10 ++++++----
>  include/linux/mfd/cs42l43.h | 13 +++++++------
>  5 files changed, 30 insertions(+), 13 deletions(-)

-- 
Lee Jones [李琼斯]