linux-kernel - Re: [PATCH v2 23/28] spi: s3c64xx: retrieve the FIFO size from the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c4a90f0-b40e-41e8-8950-16863cbd4c07@sirena.org.uk>
Date: Fri, 26 Jan 2024 21:19:09 +0000
From: Mark Brown <broonie@...nel.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Sam Protsenko <semen.protsenko@...aro.org>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Andi Shyti <andi.shyti@...nel.org>,
	Rob Herring <robh+dt@...nel.org>, krzysztof.kozlowski+dt@...aro.org,
	Conor Dooley <conor+dt@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>, linux-spi@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Linux-Arch <linux-arch@...r.kernel.org>,
	André Draszik <andre.draszik@...aro.org>,
	Peter Griffin <peter.griffin@...aro.org>, kernel-team@...roid.com,
	William McVicker <willmcvicker@...gle.com>
Subject: Re: [PATCH v2 23/28] spi: s3c64xx: retrieve the FIFO size from the
 device tree

On Fri, Jan 26, 2024 at 09:16:53PM +0100, Arnd Bergmann wrote:

> That sounds like the same bug as in the serial port driver,
> by assuming that the alias values in the devicetree have
> a particular meaning in identifying instances. This immediately
> breaks when there is a dtb file that does not use the same
> alias values, e.g. because it only needs some of the SPI
> ports.

It'll be the result of a conversion from board files where that was a
normal way of doing things.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)