linux-kernel - Re: [PATCH net] bnxt_en: Make PTP timestamp HWRM more silent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 26 Jan 2024 22:10:24 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Breno Leitao <leitao@...ian.org>
Cc: pavan.chebbi@...adcom.com, michael.chan@...adcom.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 richardcochran@...il.com, gospo@...adcom.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Make PTP timestamp HWRM more silent

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 25 Jan 2024 05:41:03 -0800 you wrote:
> commit 056bce63c469 ("bnxt_en: Make PTP TX timestamp HWRM query silent")
> changed a netdev_err() to netdev_WARN_ONCE().
> 
> netdev_WARN_ONCE() is it generates a kernel WARNING, which is bad, for
> the following reasons:
> 
>  * You do not a kernel warning if the firmware queries are late
>  * In busy networks, timestamp query failures fairly regularly
>  * A WARNING message doesn't bring much value, since the code path
> is clear.
> (This was discussed in-depth in [1])
> 
> [...]

Here is the summary with links:
  - [net] bnxt_en: Make PTP timestamp HWRM more silent
    https://git.kernel.org/netdev/net/c/281cb9d65a95

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html