linux-kernel - Re: [PATCH net] net/smc: fix incorrect SMC-D link group matching logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170630702469.26145.8407281649456707093.git-patchwork-notify@kernel.org>
Date: Fri, 26 Jan 2024 22:10:24 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Wen Gu <guwen@...ux.alibaba.com>
Cc: wintera@...ux.ibm.com, mjrosato@...ux.ibm.com, wenjia@...ux.ibm.com,
 jaka@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, alibuda@...ux.alibaba.com,
 tonylu@...ux.alibaba.com, linux-s390@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/smc: fix incorrect SMC-D link group matching logic

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 25 Jan 2024 20:39:16 +0800 you wrote:
> The logic to determine if SMC-D link group matches is incorrect. The
> correct logic should be that it only returns true when the GID is the
> same, and the SMC-D device is the same and the extended GID is the same
> (in the case of virtual ISM).
> 
> It can be fixed by adding brackets around the conditional (or ternary)
> operator expression. But for better readability and maintainability, it
> has been changed to an if-else statement.
> 
> [...]

Here is the summary with links:
  - [net] net/smc: fix incorrect SMC-D link group matching logic
    https://git.kernel.org/netdev/net/c/c3dfcdb65ec1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html