linux-kernel - Re: [PATCH v2] mtd: spinand: add support for ESMT F50x1G41LB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJsYDVLGjXXNrTicQpOd+rnAKpLpFttkeOSH15_qs5ymm+HaBQ@mail.gmail.com>
Date: Fri, 26 Jan 2024 09:45:39 +0800
From: Chuanhong Guo <gch981213@...il.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Ezra Buehler <ezra@...yb.ch>, linux-mtd@...ts.infradead.org, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	Patrice Chotard <patrice.chotard@...s.st.com>, 
	Boris Brezillon <boris.brezillon@...labora.com>, 
	Christophe Kerello <christophe.kerello@...s.st.com>, Mark Brown <broonie@...nel.org>, 
	Daniel Palmer <daniel@...f.com>, open list <linux-kernel@...r.kernel.org>, quic_sridsn@...cinc.com, 
	quic_mdalam@...cinc.com
Subject: Re: [PATCH v2] mtd: spinand: add support for ESMT F50x1G41LB

Hi Miquel!

On Thu, Jan 25, 2024 at 1:08 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> > According to the datasheets, the ESMT chips actually have a 5 byte ID,
> > the last 3 bytes being 0x7F (JEDEC Maker Code Continuation Code). Why
> > can't we simply extend the ID in esmt.c (as you had it in your original
> > patch) and increase SPINAND_MAX_ID_LEN to 5? Or, alternatively, only
> > extend the ID to 4 bytes?
> >
> > If that is the way to go, I would be happy to provide the patches.
>
> Please send the patches. Chuanhong can you test them?

I think it should be fine to set MAX_ID_LEN to 5 and add more
0x7f to the ID definition. Unfortunately I don't have access to an
ESMT flash for a test.

-- 
Regards,
Chuanhong Guo