linux-kernel - Re: [PATCH] crypto: ccp - Fix null pointer dereference in __sev_platform_shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2fe25b0-a51c-44b8-a454-2573fe6ac651@amd.com>
Date: Fri, 26 Jan 2024 10:31:19 -0600
From: Kim Phillips <kim.phillips@....com>
To: Liam Merwick <liam.merwick@...cle.com>,
 Ashish Kalra <ashish.kalra@....com>, Tom Lendacky <thomas.lendacky@....com>,
 John Allen <john.allen@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>
Cc: "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH] crypto: ccp - Fix null pointer dereference in
 __sev_platform_shutdown_locked

On 1/26/24 5:59 AM, Liam Merwick wrote:
> On 25/01/2024 23:12, Kim Phillips wrote:
>> Fixes: 1b05ece0c9315 ("crypto: ccp - During shutdown, check SEV data pointer before using")
> 
> checkpatch warns about SHA1 of Fixes: having more than 12 chars...
> 
> However, although 1b05ece0c931 is the last commit to change this
> functionality, I think this issue exists prior to that.
> 
> 5441a07a127f ("crypto: ccp - shutdown SEV firmware on kexec")
> might be more appropriate so that it'd get applied to linux-5.15.y
> (where 1b05ece0c931 and 5441a07a127f have been backported to also)
> This patch applies cleanly to linux-5.15.y.

1b05ece0c931 fixes 5441a07a127f, and I'm assuming Fixes: are transitive.

>> Cc: stable@...r.kernel.org
>> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
>> Signed-off-by: Kim Phillips <kim.phillips@....com>
> 
> Code changes LGTM, so
> Reviewed-by: Liam Merwick <liam.merwick@...cle.com>

Thanks for your review!

Kim