linux-kernel - Re: [PATCH net-next] net: dsa: remove OF-based MDIO bus registration from DSA core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 18:53:15 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Vladimir Oltean <olteanv@...il.com>,
 Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 mithat.guner@...ont.com, erkin.bozoglu@...ont.com,
 Alvin Šipraga <ALSI@...g-olufsen.dk>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: remove OF-based MDIO bus registration
 from DSA core

On 29.01.2024 17:56, Vladimir Oltean wrote:
> On Sat, Jan 27, 2024 at 11:23:33PM -0300, Luiz Angelo Daros de Luca wrote:
>>>> IIUC, Luiz made the original patch for the realtek switches. Shouldn't
>>>> we wait until realtek registers ds->user_mii_bus on its own, before
>>>> reverting? Otherwise, you're basically saying that Luiz made the DSA
>>>> core patch without needing it.
>>>
>>> My findings point to that. Luiz made the patch to optionally register the
>>> MDIO bus of the MDIO controlled Realtek switches OF-based. So it's not
>>> necessary to wait.
>>
>> Back in the time when I wrote that code, with the phy_read/write in
>> dsa_switch_ops, the OF node was only required to associate IRQ to each
>> port. Until my patch to register its own mdiobus driver lands (I hope
>> that happens before the next version), the port status will fall back
>> to polling. I don't think it is a critical feature but I'll let the
>> maintainers decide. ACK for me.
>>
>> Regards,
>>
>> Luiz
> 
> It isn't really great that this loses IRQ support for Realtek internal PHYs,
> especially since Arınç's commit message did not estimate this would happen.
> 
> I don't see why this patch could not wait until you resubmit the realtek
> consolidation set and it gets accepted.

I agree. I didn't anticipate that realtek-mdio didn't set IRQs on PHYs for
the MDIO bus registered non-OF-based. I'd much rather wait and then send v2
with the mention to realtek-mdio removed.

Arınç