[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aeabb741-97a1-4399-905c-da0f01304a1e@gmail.com>
Date: Mon, 29 Jan 2024 16:53:19 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
Lukasz Luba <lukasz.luba@....com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Balsam CHIHI <bchihi@...libre.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-pm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Fix a memory leak
in an error handling path
On 28/01/2024 09:38, Christophe JAILLET wrote:
> If devm_krealloc() fails, then 'efuse' is leaking.
> So free it to avoid a leak.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 98d9c80bd4c6..fd4bd650c77a 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -719,8 +719,10 @@ static int lvts_calibration_read(struct device *dev, struct lvts_domain *lvts_td
>
> lvts_td->calib = devm_krealloc(dev, lvts_td->calib,
> lvts_td->calib_len + len, GFP_KERNEL);
> - if (!lvts_td->calib)
> + if (!lvts_td->calib) {
> + kfree(efuse);
> return -ENOMEM;
> + }
>
> memcpy(lvts_td->calib + lvts_td->calib_len, efuse, len);
>
Powered by blists - more mailing lists