[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a522d8de-c871-4a2e-8b07-d5693abb4a7b@linaro.org>
Date: Mon, 29 Jan 2024 18:54:40 +0100
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
Manaf Meethalavalappu Pallikunhi <quic_manafm@...cinc.com>
Cc: Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/sysfs: Always enable hysteresis write support
Hi Rafael,
On 29/01/2024 18:07, Rafael J. Wysocki wrote:
[ ... ]
>> Index: linux-pm/drivers/thermal/thermal_sysfs.c
>> ===================================================================
>> --- linux-pm.orig/drivers/thermal/thermal_sysfs.c
>> +++ linux-pm/drivers/thermal/thermal_sysfs.c
>> @@ -474,7 +474,8 @@ static int create_trip_attrs(struct ther
>> tz->trip_hyst_attrs[indx].name;
>> tz->trip_hyst_attrs[indx].attr.attr.mode = S_IRUGO;
>> tz->trip_hyst_attrs[indx].attr.show = trip_point_hyst_show;
>> - if (tz->ops->set_trip_hyst) {
>> + if (IS_ENABLED(CONFIG_THERMAL_WRITABLE_TRIPS) &&
>> + mask & (1 << indx)) {
>> tz->trip_hyst_attrs[indx].attr.attr.mode |= S_IWUSR;
>> tz->trip_hyst_attrs[indx].attr.store =
>> trip_point_hyst_store;
>
> So it looks like I need to submit this, even though I'm not sure if
> anyone cares.
>
> In any case, I care about consistency.
Yeah, sorry for the delay. I'll have a look at it tomorrow
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists