[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0g=bT4FcVHEOpU1H8EC8648EtDGEEyPL1DuwrU9_W87Zg@mail.gmail.com>
Date: Mon, 29 Jan 2024 21:45:11 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Manaf Meethalavalappu Pallikunhi <quic_manafm@...cinc.com>, Zhang Rui <rui.zhang@...el.com>,
Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/sysfs: Always enable hysteresis write support
Hi Daniel,
On Mon, Jan 29, 2024 at 6:54 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> Hi Rafael,
>
> On 29/01/2024 18:07, Rafael J. Wysocki wrote:
>
> [ ... ]
>
> >> Index: linux-pm/drivers/thermal/thermal_sysfs.c
> >> ===================================================================
> >> --- linux-pm.orig/drivers/thermal/thermal_sysfs.c
> >> +++ linux-pm/drivers/thermal/thermal_sysfs.c
> >> @@ -474,7 +474,8 @@ static int create_trip_attrs(struct ther
> >> tz->trip_hyst_attrs[indx].name;
> >> tz->trip_hyst_attrs[indx].attr.attr.mode = S_IRUGO;
> >> tz->trip_hyst_attrs[indx].attr.show = trip_point_hyst_show;
> >> - if (tz->ops->set_trip_hyst) {
> >> + if (IS_ENABLED(CONFIG_THERMAL_WRITABLE_TRIPS) &&
> >> + mask & (1 << indx)) {
> >> tz->trip_hyst_attrs[indx].attr.attr.mode |= S_IWUSR;
> >> tz->trip_hyst_attrs[indx].attr.store =
> >> trip_point_hyst_store;
> >
> > So it looks like I need to submit this, even though I'm not sure if
> > anyone cares.
> >
> > In any case, I care about consistency.
>
> Yeah, sorry for the delay. I'll have a look at it tomorrow
Thanks!
Posted here with some additional remarks:
https://lore.kernel.org/linux-pm/4565526.LvFx2qVVIh@kreacher/
Let's continue the discussion there.
Powered by blists - more mailing lists