[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3e67441a-aafa-403e-b332-c58c5fa75e30@gmail.com>
Date: Mon, 29 Jan 2024 21:04:23 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Meir Elisha <meir6264@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans de Goede <hdegoede@...hat.com>, Ruan Jinjie <ruanjinjie@...wei.com>,
Yang Yingliang <yangyingliang@...wei.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Staging: rtl8723bs: checkpatch fixes for rtw_mlme.c
On 1/29/24 15:18, Meir Elisha wrote:
> Checkpatch fix series for rtw_mlme.c
>
> Meir Elisha (4):
> Staging: rtl8723bs: Remove unnecessary braces
> Staging: rtl8723bs: Remove extra spaces
> Staging: rtl8723bs: Fix block comments warning
> Staging: rtl8723bs: fix else after break warning
>
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 241 ++++++++++------------
> 1 file changed, 114 insertions(+), 127 deletions(-)
>
Hi,
please also fix:
CHECK: From:/Signed-off-by: email comments mismatch: 'From: Meir Elisha
<meir6264@...il.com>' != 'Signed-off-by: Meir Elisha <meir6264@...il.com>'
In Patch 4/4
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
Please issue a V2 with changelog.
Thanks
Bye Philipp
Powered by blists - more mailing lists