linux-kernel - Re: [PATCH v2 1/4] ARM: dts: qcom: msm8974: Split out common part of samsung-klte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <509ef748-80e7-490b-a096-80c942eba92d@linaro.org>
Date: Mon, 29 Jan 2024 09:22:23 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rong Zhang <i@...g.moe>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Icenowy Zheng <uwu@...nowy.me>
Subject: Re: [PATCH v2 1/4] ARM: dts: qcom: msm8974: Split out common part of
 samsung-klte

On 27/01/2024 18:21, Rong Zhang wrote:
> Samsung Galaxy S5 has many variants. Variants that support LTE use klte*
> as their codename. Currently, the only supported one is the one without
> any suffix, namely, klte. It is known that other klte* variants have
> only minor differences compared to klte and can mostly work with the
> klte DTB.
> 
> Split the common part into a common DTSI so that it can be imported in
> the DTS of klte and other klte* variants.
> 
> Signed-off-by: Rong Zhang <i@...g.moe>
> ---
>  .../qcom-msm8974pro-samsung-klte-common.dtsi  | 812 +++++++++++++++++
>  .../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 813 +-----------------
>  2 files changed, 818 insertions(+), 807 deletions(-)

Why code move is not detected? It's difficult to review it. You moved
almost 100% of lines. Please use correct -B/-M/-C arguments when
generating patch and create new one with proper code move.

Best regards,
Krzysztof