linux-kernel - Re: [PATCH v2 3/4] dt-bindings: arm: qcom: Add Samsung Galaxy S5 China (kltechn)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <456b4faf8d2e06423bf66ebe1ff1462230354a84.camel@rong.moe>
Date: Mon, 29 Jan 2024 16:40:09 +0800
From: Rong Zhang <i@...g.moe>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Rob
 Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>,  Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Icenowy Zheng <uwu@...nowy.me>
Subject: Re: [PATCH v2 3/4] dt-bindings: arm: qcom: Add Samsung Galaxy S5
 China (kltechn)

On Mon, 2024-01-29 at 09:20 +0100, Krzysztof Kozlowski wrote:
> On 27/01/2024 18:21, Rong Zhang wrote:
> > Document Samsung Galaxy S5 China (kltechn) as a klte variant based on
> > msm8974pro. Also including "samsung,klte" in the compatible chain as
> > kltechn works fine with the klte DTB except for LEDs and WiFi missing.
> > 
> > Signed-off-by: Rong Zhang <i@...g.moe>
> > ---
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Sorry for forgetting that. I will check more precisely the next time.

> If a tag was not added on purpose, please state why and what changed.

I meant not to add your Acked-by because the dt-binding has changed
into a different form to make it consistent with the kltechn DTS. I
should have stated it but hopefully it's not too late to ask if the new
dt-binding is still eligible to receive your ACK.


Thanks,
Rong