linux-kernel - Re: [RFC PATCH] nvmem: u-boot-env: improve error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43112f7f-b416-4c76-a636-0fb45e9f558b@moroto.mountain>
Date: Mon, 29 Jan 2024 12:00:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Nick Spooner <nicholas.spooner@...gate.com>
Cc: "rafal@...ecki.pl" <rafal@...ecki.pl>,
	"srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
	Evan Burgess <evan.burgess@...gate.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [RFC PATCH] nvmem: u-boot-env: improve error checking

Your patch is white space damaged and doesn't apply.  Read the first
paragraph of Documentation/process/email-clients.rst

On Fri, Jan 26, 2024 at 11:10:06PM +0000, Nick Spooner wrote:
> Coverity scan reported CID 1575482: error handling issues; this patch
> addresses this by adding error handling to u_boot_env_add_cells.
> 
> I added the RFC tag to this patch since I'm not confident about the
> logic here.

Just put this kind of comments under the --- cut off line.  We're used
to reviewing patches like this so it's not a big deal.

> The check is reused from nvmem_add_cells in core.c, which
> doesn't include an of_node_put on a device_node, whereas
> nvmem_add_cells_from_dt does. Without much certainty, I went with the
> less complex option and added it here. Any advice or suggested fixes to
> this patch are welcome!
> 

nvmem_add_cells_from_dt() is cleaning up from:
	addr = of_get_property(child, "reg", &len);
so that's why it does:
	of_node_put(child);

It's not necessary in u_boot_env_add_cells().

regards,
dan carpenter