linux-kernel - Re: [PATCH 5/9] arm64: dts: exynos: gs101: define USI12 with I2C configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <219a57cc21d670c19745a4861e83dd79d4ea2b68.camel@linaro.org>
Date: Mon, 29 Jan 2024 10:26:40 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Sam Protsenko <semen.protsenko@...aro.org>
Cc: peter.griffin@...aro.org, mturquette@...libre.com, sboyd@...nel.org, 
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
  linux-kernel@...r.kernel.org, kernel-team@...roid.com,
 tudor.ambarus@...aro.org,  willmcvicker@...gle.com,
 alim.akhtar@...sung.com, s.nawrocki@...sung.com,  tomasz.figa@...il.com,
 cw00.choi@...sung.com,  linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org,  linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 5/9] arm64: dts: exynos: gs101: define USI12 with I2C
 configuration

On Fri, 2024-01-26 at 20:55 -0600, Sam Protsenko wrote:
> On Fri, Jan 26, 2024 at 6:19 PM André Draszik <andre.draszik@...aro.org> wrote:
> > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> > @@ -450,6 +450,36 @@ pinctrl_peric1: pinctrl@...40000 {
> >                         interrupts = <GIC_SPI 644 IRQ_TYPE_LEVEL_HIGH 0>;
> >                 };
> > 
> > +               usi12: usi@...500c0 {
> > +                       compatible = "google,gs101-usi",
> > +                                    "samsung,exynos850-usi";
> 
> It doesn't fit on one line?

No, it's 81 characters. While I know it's not a hard rule in this case,
there are other cases in this file where the line was split in the same
way, so I followed that.

> > +                               pinctrl-names = "default";
> > +                               pinctrl-0 = <&hsi2c12_bus>;
> 
> I remember Krzysztof asked me to put pinctrl-0 first in my recent
> patches. Not sure how important it is, just saying. Other than that,

Makes sense, this came from a copy/paste and I have fixed it.

Cheers,
Andre'