linux-kernel - Re: [PATCH 6/9] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 10:40:02 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Sam Protsenko <semen.protsenko@...aro.org>
Cc: peter.griffin@...aro.org, mturquette@...libre.com, sboyd@...nel.org, 
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
  linux-kernel@...r.kernel.org, kernel-team@...roid.com,
 tudor.ambarus@...aro.org,  willmcvicker@...gle.com,
 alim.akhtar@...sung.com, s.nawrocki@...sung.com,  tomasz.figa@...il.com,
 cw00.choi@...sung.com,  linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org,  linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 6/9] arm64: dts: exynos: gs101: enable i2c bus 12 on
 gs101-oriole

Hi Sam,

On Fri, 2024-01-26 at 20:58 -0600, Sam Protsenko wrote:
> On Fri, Jan 26, 2024 at 6:19 PM André Draszik <andre.draszik@...aro.org> wrote:
> > 
> > This bus has various USB-related devices attached to it.
> > 
> > [...]
> > 
> > +&hsi2c_12 {
> > +       status = "okay";
> 
> But there are no bus clients declared here? A bit of explanation about
> how this bus is being currently used would be nice to have (in commit
> message); e.g. maybe it's used in user space somehow, etc. Because
> otherwise it doesn't have much sense to enable the bus with no users.

As per the commit message, there are devices, but:
* most or all don't have an upstream driver at this stage
* it does make sense to enable the bus, as enabling it allows working on
  the drivers for the devices that are attached to this bus

Cheers,
Andre'