linux-kernel - Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795e2da5ae251321279920ee57c3d033@kernel.org>
Date: Mon, 29 Jan 2024 11:39:20 +0100
From: Michael Walle <mwalle@...nel.org>
To: Dave Airlie <airlied@...il.com>
Cc: Inki Dae <daeinki@...il.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Robert Foss <rfoss@...nel.org>, Frieder
 Schrempf <frieder.schrempf@...tron.de>, Jagan Teki
 <jagan@...rulasolutions.com>, Andrzej Hajda <andrzej.hajda@...el.com>, Marek
 Szyprowski <m.szyprowski@...sung.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Tim Harvey
 <tharvey@...eworks.com>, Alexander Stein <alexander.stein@...tq-group.com>,
 linux-kernel@...r.kernel.org, DRI mailing list
 <dri-devel@...ts.freedesktop.org>, Daniel Vetter <daniel@...ll.ch>, Michael
 Trimarchi <michael@...rulasolutions.com>, Dario Binacchi
 <dario.binacchi@...rulasolutions.com>, Dmitry Osipenko
 <dmitry.osipenko@...labora.com>
Subject: Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

> Also merge commit 663a907e199b (Merge remote-tracking branch
> 'drm-misc/drm-misc-next' into drm-tip) is broken because it
> completely removes samsung_dsim_atomic_disable(). Dunno whats
> going on there.

Actually, that merge commit looks even worse. It somehow folds
the original samsung_dsim_atomic_disable() into
samsung_dsim_atomic_enable(). Therefore, now the enable op
will clear the DSIM_STATE_VIDOUT_AVAILABLE flag?! It will also
never be set. Dunno how to proceed here.

-michael