linux-kernel - Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31e1a38a1d012a32d6f7bc8372b6360e@kernel.org>
Date: Mon, 29 Jan 2024 17:06:22 +0100
From: Michael Walle <mwalle@...nel.org>
To: Dave Airlie <airlied@...il.com>, Dario Binacchi
 <dario.binacchi@...rulasolutions.com>, Dmitry Osipenko
 <dmitry.osipenko@...labora.com>
Cc: Inki Dae <daeinki@...il.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Robert Foss <rfoss@...nel.org>, Frieder
 Schrempf <frieder.schrempf@...tron.de>, Jagan Teki
 <jagan@...rulasolutions.com>, Andrzej Hajda <andrzej.hajda@...el.com>, Marek
 Szyprowski <m.szyprowski@...sung.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Tim Harvey
 <tharvey@...eworks.com>, Alexander Stein <alexander.stein@...tq-group.com>,
 linux-kernel@...r.kernel.org, DRI mailing list
 <dri-devel@...ts.freedesktop.org>, Daniel Vetter <daniel@...ll.ch>, Michael
 Trimarchi <michael@...rulasolutions.com>
Subject: Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

>> Just FYI this conflictted pretty heavily with drm-misc-next changes in
>> the same area, someone should check drm-tip has the correct
>> resolution, I'm not really sure what is definitely should be.
> 
> FWIW, this looks rather messy now. The drm-tip doesn't build.
> 
> There was a new call to samsung_dsim_set_stop_state() introduced
> in commit b2fe2292624ac (drm: bridge: samsung-dsim: enter display
> mode in the enable() callback).

I had a closer look at the latest linux-next (where somehow my patch
made it into) and tried to apply commit b2fe2292624ac (drm: bridge:
samsung-dsim: enter display mode in the enable() callback). It looks
like only the following hunk is still needed from that patch. Everything
else is covered by this fixes patch.

Dario, could you rebase your commit onto this patch? I had a quick test
with this change and it seems to work fine for our case.

--snip--
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c 
b/drivers/gpu/drm/bridge/samsung-dsim.c
index 63a1a0c88be4..92755c90e7d2 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1498,6 +1498,8 @@ static void samsung_dsim_atomic_disable(struct 
drm_bridge *bridge,
         if (!(dsi->state & DSIM_STATE_ENABLED))
                 return;

+       samsung_dsim_set_display_enable(dsi, false);
+
         dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE;
  }

@@ -1506,8 +1508,6 @@ static void 
samsung_dsim_atomic_post_disable(struct drm_bridge *bridge,
  {
         struct samsung_dsim *dsi = bridge_to_dsi(bridge);

-       samsung_dsim_set_display_enable(dsi, false);
-
         dsi->state &= ~DSIM_STATE_ENABLED;
         pm_runtime_put_sync(dsi->dev);
  }
--snip--

-michael