linux-kernel - Re: [PATCH v8 0/7] Fixes and improvements for RS485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 29 Jan 2024 03:39:25 +0100
From: Lino Sanfilippo <l.sanfilippo@...bus.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com,
 u.kleine-koenig@...gutronix.de, shawnguo@...nel.org, s.hauer@...gutronix.de,
 mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
 cniedermaier@...electronics.com, hugo@...ovil.com, m.brock@...mierlo.com,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 LinoSanfilippo@....de, lukas@...ner.de, p.rosenberger@...bus.com
Subject: Re: [PATCH v8 0/7] Fixes and improvements for RS485

Hi,

On 28.01.24 04:10, Greg KH wrote:
> ATTENTION: This e-mail is from an external sender. Please check attachments and links before opening e.g. with mouseover.
> 
> 
> On Fri, Jan 05, 2024 at 03:11:46PM +0100, Lino Sanfilippo wrote:
>> The following series includes some fixes and improvements around RS485 in
>> the serial core and UART drivers:
>>
>> Patch 1: serial: Do not hold the port lock when setting rx-during-tx GPIO
>> Patch 2: serial: core: set missing supported flag for RX during TX GPIO
>> Patch 3: serial: core: fix sanitizing check for RTS settings
>> Patch 4: serial: core: make sure RS485 cannot be enabled when it is not
>> supported
>> Patch 5: serial: core, imx: do not set RS485 enabled if it is not supported
>> Patch 6: serial: omap: do not override settings for RS485 support
>> Patch 7: serial: 8250_exar: Set missing rs485_supported flag
>>
>> Changes in v8:
>> - remove wrong setting of SER_RS485_RX_DURING_TX introduced with patch
>>   version 7 (pointed out by Ilpo)
>> - fix commit message as pointed out by Ilpo
> 
> Aren't these already in the tree?  None of them apply, what am I doing
> wrong?
> 
> confused,
> 
> greg k-h


Right, the series is already applied. However patch 1 - 
07c30ea5861f (" serial: Do not hold the port lock when setting rx-during-tx GPIO") -
still contains a flaw which is why I sent a v8 to correct that. I sent it a bit too late
obviously, sorry for that.
You can ignore series v8 and instead I can send a follow up patch that corrects the flaw.

Again, sorry for the confusion.

Regards,
Lino