[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <080d2c0d-49b1-45e9-9b7b-fae2afaf0b4f@moroto.mountain>
Date: Mon, 29 Jan 2024 18:05:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Meir Elisha <meir6264@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans de Goede <hdegoede@...hat.com>,
Ruan Jinjie <ruanjinjie@...wei.com>,
Yang Yingliang <yangyingliang@...wei.com>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Staging: rtl8723bs: Remove extra spaces
On Mon, Jan 29, 2024 at 04:18:54PM +0200, Meir Elisha wrote:
> Fix checkpatch warning: please, no space before tabs
>
> Signed-off-by: Meir Elisha <meir6264@...il.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 48 +++++++++++------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 5568215b35bd..a7c4350e0783 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -169,7 +169,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwor
> {
> unsigned int delta_time;
> u32 lifetime = SCANQUEUE_LIFETIME;
> -/* _irqL irqL; */
> +/* _irqL irqL; */
Just delete dead code.
> struct __queue *free_queue = &(pmlmepriv->free_bss_pool);
>
> if (!pnetwork)
> @@ -389,7 +389,7 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
> d_cap = le16_to_cpu(tmpd);
>
> return (src->ssid.ssid_length == dst->ssid.ssid_length) &&
> - /* (src->configuration.ds_config == dst->configuration.ds_config) && */
> + /* (src->configuration.ds_config == dst->configuration.ds_config) && */
Here too.
> ((!memcmp(src->mac_address, dst->mac_address, ETH_ALEN))) &&
> ((!memcmp(src->ssid.ssid, dst->ssid.ssid, src->ssid.ssid_length))) &&
> ((s_cap & WLAN_CAPABILITY_IBSS) ==
regards,
dan carpenter
Powered by blists - more mailing lists