linux-kernel - Re: [PATCH 3/4] Staging: rtl8723bs: Fix block comments warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888364a5-0445-467b-9e3c-6662019852e4@moroto.mountain>
Date: Mon, 29 Jan 2024 18:06:34 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Meir Elisha <meir6264@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Ruan Jinjie <ruanjinjie@...wei.com>,
	Yang Yingliang <yangyingliang@...wei.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Staging: rtl8723bs: Fix block comments warning

On Mon, Jan 29, 2024 at 04:18:55PM +0200, Meir Elisha wrote:
>  /*
> -struct	wlan_network *_rtw_dequeue_network(struct __queue *queue)
> -{
> -	_irqL irqL;
> -
> -	struct wlan_network *pnetwork;
> -
> -	spin_lock_bh(&queue->lock);
> -
> -	if (list_empty(&queue->queue))
> -
> -		pnetwork = NULL;
> -
> -	else
> -	{
> -		pnetwork = container_of(get_next(&queue->queue), struct wlan_network, list);
> -
> -		list_del_init(&(pnetwork->list));
> -	}
> -
> -	spin_unlock_bh(&queue->lock);
> -
> -	return pnetwork;
> -}
> -*/
> + *struct wlan_network *_rtw_dequeue_network(struct __queue *queue)
> + *{
> + *	_irqL irqL;
> + *
> + *	struct wlan_network *pnetwork;
> + *
> + *	spin_lock_bh(&queue->lock);
> + *
> + *	if (list_empty(&queue->queue))
> + *
> + *		pnetwork = NULL;
> + *
> + *	else
> + *	{
> + *		pnetwork = container_of(get_next(&queue->queue), struct wlan_network, list);
> + *
> + *		list_del_init(&(pnetwork->list));
> + *	}
> + *
> + *	spin_unlock_bh(&queue->lock);
> + *
> + *	return pnetwork;
> + *}
> + */


Delete the dead code.

regards,
dan carpenter