linux-kernel - Re: [PATCH v9 05/27] x86/fpu/xstate: Introduce fpu_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 30 Jan 2024 23:00:31 +0800
From: "Yang, Weijiang" <weijiang.yang@...el.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
CC: "Hansen, Dave" <dave.hansen@...el.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>, "yuan.yao@...ux.intel.com" <yuan.yao@...ux.intel.com>,
	"john.allen@....com" <john.allen@....com>, "peterz@...radead.org"
	<peterz@...radead.org>, "Gao, Chao" <chao.gao@...el.com>,
	"mlevitsk@...hat.com" <mlevitsk@...hat.com>
Subject: Re: [PATCH v9 05/27] x86/fpu/xstate: Introduce fpu_guest_cfg for
 guest FPU configuration

On 1/30/2024 9:29 AM, Edgecombe, Rick P wrote:
> On Tue, 2024-01-23 at 18:41 -0800, Yang Weijiang wrote:
>> Define new fpu_guest_cfg to hold all guest FPU settings so that it
>> can
>> differ from generic kernel FPU settings, e.g., enabling CET
>> supervisor
>> xstate by default for guest fpstate while it's remained disabled in
>> kernel FPU config.
>>
>> The kernel dynamic xfeatures are specifically used by guest fpstate
>> now,
>> add the mask for guest fpstate so that guest_perm.__state_permit ==
> I think you mean 'guest_perm.__state_perm'.

Yes, will change it, thanks!

>
> Otherwise:
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
>
>