linux-kernel - RE: [PATCH 2/2] x86/fred: Fix build with CONFIG_IA32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR11MB67344899D3BCCD4165249D8DA87D2@SA1PR11MB6734.namprd11.prod.outlook.com>
Date: Tue, 30 Jan 2024 16:30:34 +0000
From: "Li, Xin3" <xin3.li@...el.com>
To: Borislav Petkov <bp@...en8.de>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com"
	<mingo@...hat.com>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>,
	"hpa@...or.com" <hpa@...or.com>, "luto@...nel.org" <luto@...nel.org>,
	"Shankar, Ravi V" <ravi.v.shankar@...el.com>, "andrew.cooper3@...rix.com"
	<andrew.cooper3@...rix.com>, Peter Zijlstra <peterz@...radead.org>
Subject: RE: [PATCH 2/2] x86/fred: Fix build with CONFIG_IA32_EMULATION=n

> On Tue, Jan 30, 2024 at 03:22:01PM +0000, Li, Xin3 wrote:
> > How do you think?
> 
> Interesting. For some reason gcc doesn't constant-fold it away like clang does.

Even more interesting, gcc doesn't complain it with the attached config
File in which CONFIG_X86_FRED=y and CONFIG_IA32_EMULATION not set.

I compared the 2 config files, nothing suspicious to me.

CCing PeterZ to give insights 😊

> > diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> > index c7ef6ea2fa99..01342d343c19 100644
> > --- a/arch/x86/include/asm/ia32.h
> > +++ b/arch/x86/include/asm/ia32.h
> > @@ -81,7 +81,7 @@ static inline void ia32_disable(void)
> >
> >  #else /* !CONFIG_IA32_EMULATION */
> >
> > -static inline bool ia32_enabled(void)
> > +static __always_inline bool ia32_enabled(void)
> >  {
> >  	return IS_ENABLED(CONFIG_X86_32);
> >  }
> 
> Looks good to me. Lemme try it here.

Thank you very much!
        -Xin

Download attachment "fred-no_ia32_emu.config" of type "application/octet-stream" (176836 bytes)