linux-kernel - Re: [PATCH 06/20] mm: zswap: rename __zswap_load() to zswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=N-n8Eps4ohERxRYAPSRYzpxpOW_1fzUfrpUq7P=1DZFg@mail.gmail.com>
Date: Tue, 30 Jan 2024 08:33:18 -0800
From: Nhat Pham <nphamcs@...il.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Yosry Ahmed <yosryahmed@...gle.com>, 
	Chengming Zhou <zhouchengming@...edance.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/20] mm: zswap: rename __zswap_load() to zswap_decompress()

On Mon, Jan 29, 2024 at 5:42 PM Johannes Weiner <hannes@...xchg.org> wrote:
>
> Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> ---
>  mm/zswap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 7a7e8da2b4f8..bdc9f82fe4b9 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1316,7 +1316,7 @@ static int zswap_enabled_param_set(const char *val,
>         return ret;
>  }
>
> -static void __zswap_load(struct zswap_entry *entry, struct page *page)
> +static void zswap_decompress(struct zswap_entry *entry, struct page *page)

This is a much better name. Was gonna point this out in the original
series - it's clearly just decompression :)
Reviewed-by: Nhat Pham <nphamcs@...il.com>

>  {
>         struct zpool *zpool = zswap_find_zpool(entry);
>         struct scatterlist input, output;
> @@ -1411,7 +1411,7 @@ static int zswap_writeback_entry(struct zswap_entry *entry,
>         zswap_entry_get(entry);
>         spin_unlock(&tree->lock);
>
> -       __zswap_load(entry, &folio->page);
> +       zswap_decompress(entry, &folio->page);
>
>         count_vm_event(ZSWPWB);
>         if (entry->objcg)
> @@ -1702,7 +1702,7 @@ bool zswap_load(struct folio *folio)
>         spin_unlock(&tree->lock);
>
>         if (entry->length)
> -               __zswap_load(entry, page);
> +               zswap_decompress(entry, page);
>         else {
>                 dst = kmap_local_page(page);
>                 zswap_fill_page(dst, entry->value);
> --
> 2.43.0
>