linux-kernel - Re: [PATCH] nfsd: Simplify the allocation of slab caches in nfsd_file_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZbpoOtZlxt7gWEyI@tissot.1015granger.net>
Date: Wed, 31 Jan 2024 10:33:14 -0500
From: Chuck Lever <chuck.lever@...cle.com>
To: Kunwu Chan <chentao@...inos.cn>
Cc: jlayton@...nel.org, neilb@...e.de, kolga@...app.com, Dai.Ngo@...cle.com,
        tom@...pey.com, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: Simplify the allocation of slab caches in
 nfsd_file_cache_init

On Wed, Jan 31, 2024 at 02:56:53PM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>  fs/nfsd/filecache.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 8d9f7b07e35b..f3a642fd0eca 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -722,15 +722,13 @@ nfsd_file_cache_init(void)
>  		return ret;
>  
>  	ret = -ENOMEM;
> -	nfsd_file_slab = kmem_cache_create("nfsd_file",
> -				sizeof(struct nfsd_file), 0, 0, NULL);
> +	nfsd_file_slab = KMEM_CACHE(nfsd_file, 0);
>  	if (!nfsd_file_slab) {
>  		pr_err("nfsd: unable to create nfsd_file_slab\n");
>  		goto out_err;
>  	}
>  
> -	nfsd_file_mark_slab = kmem_cache_create("nfsd_file_mark",
> -					sizeof(struct nfsd_file_mark), 0, 0, NULL);
> +	nfsd_file_mark_slab = KMEM_CACHE(nfsd_file_mark, 0);
>  	if (!nfsd_file_mark_slab) {
>  		pr_err("nfsd: unable to create nfsd_file_mark_slab\n");
>  		goto out_err;
> -- 
> 2.39.2

Applied to nfsd-next (for v6.9).


-- 
Chuck Lever