linux-kernel - Re: [PATCH] smb: client: Fix a NULL vs IS_ERR() check in wsl_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0861faa7b564362e384783d4e52e38c@manguebit.com>
Date: Wed, 31 Jan 2024 14:23:13 -0300
From: Paulo Alcantara <pc@...guebit.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Steve French <sfrench@...ba.org>, Ronnie Sahlberg
 <ronniesahlberg@...il.com>, Shyam Prasad N <sprasad@...rosoft.com>, Tom
 Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org,
 samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] smb: client: Fix a NULL vs IS_ERR() check in
 wsl_set_xattrs()

Dan Carpenter <dan.carpenter@...aro.org> writes:

> This was intended to be an IS_ERR() check.  The ea_create_context()
> function doesn't return NULL.
>
> Fixes: 1eab17fe485c ("smb: client: add support for WSL reparse points")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  fs/smb/client/reparse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Paulo Alcantara <pc@...guebit.com>