linux-kernel - Re: [PATCH] smb: client: Fix a NULL vs IS_ERR() check in wsl_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 31 Jan 2024 14:20:36 -0600
From: Steve French <smfrench@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Paulo Alcantara <pc@...guebit.com>, Steve French <sfrench@...ba.org>, 
	Ronnie Sahlberg <ronniesahlberg@...il.com>, Shyam Prasad N <sprasad@...rosoft.com>, 
	Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org, 
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] smb: client: Fix a NULL vs IS_ERR() check in wsl_set_xattrs()

Good catch.  Thx.

Added Paulo's RB and added to cifs-2.6.git for-next


On Wed, Jan 31, 2024 at 1:17 AM Dan Carpenter <dan.carpenter@...aroorg> wrote:
>
> This was intended to be an IS_ERR() check.  The ea_create_context()
> function doesn't return NULL.
>
> Fixes: 1eab17fe485c ("smb: client: add support for WSL reparse points")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  fs/smb/client/reparse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c
> index ce69d67feefa..d4d2555ebd38 100644
> --- a/fs/smb/client/reparse.c
> +++ b/fs/smb/client/reparse.c
> @@ -225,7 +225,7 @@ static int wsl_set_xattrs(struct inode *inode, umode_t mode,
>         }
>
>         cc = ea_create_context(dlen, &cc_len);
> -       if (!cc)
> +       if (IS_ERR(cc))
>                 return PTR_ERR(cc);
>
>         ea = &cc->ea;
> --
> 2.43.0
>
>


-- 
Thanks,

Steve