Message-ID: <8a15ae5e-e949-4177-9737-84aa471c300d@linaro.org>
Date: Wed, 31 Jan 2024 11:12:27 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yann Sionneau <ysionneau@...rayinc.com>,
 Yann Sionneau <ysionneau@...ray.eu>, Arnd Bergmann <arnd@...db.de>,
 Jonathan Corbet <corbet@....net>, Thomas Gleixner <tglx@...utronix.de>,
 Marc Zyngier <maz@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Will Deacon <will@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Boqun Feng <boqun.feng@...il.com>, Mark Rutland <mark.rutland@....com>,
 Eric Biederman <ebiederm@...ssion.com>, Kees Cook <keescook@...omium.org>,
 Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...hat.com>,
 Waiman Long <longman@...hat.com>,
 "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Nick Piggin <npiggin@...il.com>,
 Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
 Christian Brauner <brauner@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Jules Maselbas <jmaselbas@...ray.eu>,
 Guillaume Thouvenin <gthouvenin@...ray.eu>,
 Clement Leger <clement@...ment-leger.fr>,
 Vincent Chardon <vincent.chardon@...ys-design.com>,
 Marc Poulhiès <dkm@...aplop.net>,
 Julian Vetter <jvetter@...ray.eu>, Samuel Jones <sjones@...ray.eu>,
 Ashley Lesdalons <alesdalons@...ray.eu>, Thomas Costis <tcostis@...ray.eu>,
 Marius Gligor <mgligor@...ray.eu>, Jonathan Borne <jborne@...ray.eu>,
 Julien Villette <jvillette@...ray.eu>, Luc Michel <lmichel@...ray.eu>,
 Louis Morhet <lmorhet@...ray.eu>, Julien Hascoet <jhascoet@...ray.eu>,
 Jean-Christophe Pince <jcpince@...il.com>,
 Guillaume Missonnier <gmissonnier@...ray.eu>, Alex Michon
 <amichon@...ray.eu>, Huacai Chen <chenhuacai@...nel.org>,
 WANG Xuerui <git@...0n.name>, Shaokun Zhang <zhangshaokun@...ilicon.com>,
 John Garry <john.garry@...wei.com>,
 Guangbin Huang <huangguangbin2@...wei.com>,
 Bharat Bhushan <bbhushan2@...vell.com>, Bibo Mao <maobibo@...ngson.cn>,
 Atish Patra <atishp@...shpatra.org>, "Jason A. Donenfeld" <Jason@...c4.com>,
 Qi Liu <liuqi115@...wei.com>, Jiaxun Yang <jiaxun.yang@...goat.com>,
 Catalin Marinas <catalin.marinas@....com>, Mark Brown <broonie@...nel.org>,
 Janosch Frank <frankja@...ux.ibm.com>, Alexey Dobriyan
 <adobriyan@...il.com>, Julian Vetter <jvetter@...rayinc.com>,
 jmaselbas@...v.net
Cc: Benjamin Mugnier <mugnier.benjamin@...il.com>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-mm@...ck.org, linux-arch@...r.kernel.org, linux-audit@...hat.com,
 linux-riscv@...ts.infradead.org, bpf@...r.kernel.org
Subject: Re: [RFC PATCH v2 31/31] kvx: Add IPI driver

On 31/01/2024 10:52, Yann Sionneau wrote:
> Hello Krzysztof,
> 
> On 22/01/2023 12:54, Krzysztof Kozlowski wrote:
>> On 20/01/2023 15:10, Yann Sionneau wrote:
>>> +
>>> +int __init kvx_ipi_ctrl_probe(irqreturn_t (*ipi_irq_handler)(int, void *))
>>> +{
>>> +	struct device_node *np;
>>> +	int ret;
>>> +	unsigned int ipi_irq;
>>> +	void __iomem *ipi_base;
>>> +
>>> +	np = of_find_compatible_node(NULL, NULL, "kalray,kvx-ipi-ctrl");
>> Nope, big no.
>>
>> Drivers go to drivers, not to arch code. Use proper driver infrastructure.
> Thank you for your review.
> 
> It raises questions on our side about how to handle this change.

I am sorry, but responding with one page of hardware description is
totally unrelated to the code I am questioning here and does not make it
easier for me to respond. I understand that you want me to learn entire
new KVX architecture to be able to provide good review, but it is just
not possible, sorry. We all have quite limited time around here, so we
all expect concise and precise answers.

Best regards,
Krzysztof

Powered by blists - more mailing lists