linux-kernel - Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b99efbd4-7c12-485d-8688-a4ec606f0cf5@linaro.org>
Date: Wed, 31 Jan 2024 11:16:01 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yang Jialong 杨佳龙 <jialong.yang@...ngroup.cn>,
 will <will@...nel.org>, "mark.rutland" <mark.rutland@....com>
Cc: shenghui.qu@...ngroup.cn, 赵可 <ke.zhao@...ngroup.cn>,
 zhijie.ren@...ngroup.cn, linux-kernel@...r.kernel.org,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU

On 31/01/2024 11:13, Yang Jialong 杨佳龙 wrote:
> 
> 
> 在 2024/1/31 17:30, Krzysztof Kozlowski 写道:
>> On 31/01/2024 10:26, Yang Jialong 杨佳龙 wrote:
>>>
>>>
>>> 在 2024/1/31 15:49, Krzysztof Kozlowski 写道:
>>>> On 31/01/2024 07:59, JiaLong.Yang wrote:
>>>>> Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU driver
>>>>> for HX.
>>>>>
>>>>> Signed-off-by: JiaLong.Yang <jialong.yang@...ngroup.cn>
>>>>> ---
>>>>> v1 --> v2:
>>>>> 1. Submit dt-bindings file Seperately.
>>>>
>>>> Where is the driver?
>>>>
>>>> Please read:
>>>> https://elixir.bootlin.com/linux/v6.8-rc2/source/Documentation/process/submitting-patches.rst
>>>> before posting.
>>>>
>>
>> Keep all discussions public.
> 
> Get.
> 
>>
>>
>>>>> +  pccs-id:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>> +    description: Used to identify NIs in system which has more than
>>>>> +      one NI.
>>>>
>>>> No, reg does it. Drop the property. Anyway you miss here vendor prefix
>>>> and proper explanation.
>>>>
>>>
>>> reg will tell phy address. Phy address is too long. I just want a id.
>>> example: perf stat -a -e ni_pmu_${pccs-id}/cycles/
>>> I will use it in user space. Not only in driver.
>>
>> Custom vendor property is not for that purpose. Use for example IDR, DT
>> aliases or something else.
>>
>>
> 
> I have considered TD aliases. It's not very easy. Two places...
> IDR.. I have tested. But it chouldn't correspond to the HWs.
> I need it to identify NIs.
> DT aliases is reachable. But no very easy.

Except that "you want" I did not see any rationale, any argument
explaining why this is needed and why this has to be present.

Best regards,
Krzysztof