linux-kernel - Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EC1445AF2C5DB6F4+64772ecd-5e7a-42bb-aaa8-bc2857b2ab8b@shingroup.cn>
Date: Wed, 31 Jan 2024 18:18:07 +0800
From: Yang Jialong 杨佳龙 <jialong.yang@...ngroup.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 will <will@...nel.org>, "mark.rutland" <mark.rutland@....com>
Cc: shenghui.qu@...ngroup.cn, 赵可 <ke.zhao@...ngroup.cn>,
 zhijie.ren@...ngroup.cn, linux-kernel@...r.kernel.org,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU



在 2024/1/31 18:16, Krzysztof Kozlowski 写道:
> On 31/01/2024 11:13, Yang Jialong 杨佳龙 wrote:
>>
>>
>> 在 2024/1/31 17:30, Krzysztof Kozlowski 写道:
>>> On 31/01/2024 10:26, Yang Jialong 杨佳龙 wrote:
>>>>
>>>>
>>>> 在 2024/1/31 15:49, Krzysztof Kozlowski 写道:
>>>>> On 31/01/2024 07:59, JiaLong.Yang wrote:
>>>>>> Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU driver
>>>>>> for HX.
>>>>>>
>>>>>> Signed-off-by: JiaLong.Yang <jialong.yang@...ngroup.cn>
>>>>>> ---
>>>>>> v1 --> v2:
>>>>>> 1. Submit dt-bindings file Seperately.
>>>>>
>>>>> Where is the driver?
>>>>>
>>>>> Please read:
>>>>> https://elixir.bootlin.com/linux/v6.8-rc2/source/Documentation/process/submitting-patches.rst
>>>>> before posting.
>>>>>
>>>
>>> Keep all discussions public.
>>
>> Get.
>>
>>>
>>>
>>>>>> +  pccs-id:
>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>>> +    description: Used to identify NIs in system which has more than
>>>>>> +      one NI.
>>>>>
>>>>> No, reg does it. Drop the property. Anyway you miss here vendor prefix
>>>>> and proper explanation.
>>>>>
>>>>
>>>> reg will tell phy address. Phy address is too long. I just want a id.
>>>> example: perf stat -a -e ni_pmu_${pccs-id}/cycles/
>>>> I will use it in user space. Not only in driver.
>>>
>>> Custom vendor property is not for that purpose. Use for example IDR, DT
>>> aliases or something else.
>>>
>>>
>>
>> I have considered TD aliases. It's not very easy. Two places...
>> IDR.. I have tested. But it chouldn't correspond to the HWs.
>> I need it to identify NIs.
>> DT aliases is reachable. But no very easy.
> 
> Except that "you want" I did not see any rationale, any argument
> explaining why this is needed and why this has to be present.

OK. DT aliases it good.

> 
> Best regards,
> Krzysztof
> 
>