linux-kernel - Re: [PATCH v1] arch: arm64: dts: meson: a1: add assigned-clocks for usb node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bcfa06b-f426-4575-9359-e97e4af52465@linaro.org>
Date: Thu, 1 Feb 2024 16:33:36 +0100
From: neil.armstrong@...aro.org
To: Alexey Romanov <avromanov@...utedevices.com>, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 khilman@...libre.com, jbrunet@...libre.com,
 martin.blumenstingl@...glemail.com
Cc: linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kernel@...utedevices.com, Dmitry Rokosov <ddrokosov@...utedevices.com>
Subject: Re: [PATCH v1] arch: arm64: dts: meson: a1: add assigned-clocks for
 usb node

On 24/01/2024 14:06, Alexey Romanov wrote:
> To ensure proper functionality of USB, it is necessary to use
> the rate of 64000000 for CLKID_USB_BUS. For instance, adb may
> not function correctly without this setting. This information
> has been derived from the vendor SDK.
> 
> Signed-off-by: Alexey Romanov <avromanov@...utedevices.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@...utedevices.com>
> ---
>   arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index cf150f568335..b9fd69112535 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -668,6 +668,8 @@ usb: usb@...04400 {
>   				 <&clkc_periphs CLKID_USB_BUS>,
>   				 <&clkc_periphs CLKID_USB_CTRL_IN>;
>   			clock-names = "usb_ctrl", "usb_bus", "xtal_usb_ctrl";
> +			assigned-clocks = <&clkc_periphs CLKID_USB_BUS>;
> +			assigned-clock-rates = <64000000>;
>   			resets = <&reset RESET_USBCTRL>;
>   			reset-name = "usb_ctrl";
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>