linux-kernel - RE: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SHXPR01MB0670720DD9EAB09EE8A1B13E8A43A@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 1 Feb 2024 05:59:01 +0000
From: JiaJie Ho <jiajie.ho@...rfivetech.com>
To: 'Herbert Xu' <herbert@...dor.apana.org.au>
CC: "'David S . Miller'" <davem@...emloft.net>, 'Rob Herring'
	<robh+dt@...nel.org>, 'Krzysztof Kozlowski'
	<krzysztof.kozlowski+dt@...aro.org>, 'Conor Dooley' <conor+dt@...nel.org>,
	"'linux-crypto@...r.kernel.org'" <linux-crypto@...r.kernel.org>,
	"'devicetree@...r.kernel.org'" <devicetree@...r.kernel.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100

> On Thu, Feb 01, 2024 at 03:01:59AM +0000, JiaJie Ho wrote:
> >
> > I am using ifdef so unused codes wouldn't be compiled into the driver for
> unsupported variant.
> > Is the compiled driver size a concern for such cases?
> 
> The compiler should be eliminating unused code for you.  Is this not the case?

Currently, the object files defining new algo register/unregister functions weren't included in Makefile for unsupported device.
Compiler will still check for these definitions if IS_ENABLED is used instead of ifdef causing build errors.

Best regards,
Jia Jie