linux-kernel - Re: [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential clocks as critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dfab6a9-f9d1-46c2-8bd1-6ead4b26fbe1@linaro.org>
Date: Thu, 1 Feb 2024 11:02:27 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: André Draszik <andre.draszik@...aro.org>,
 peter.griffin@...aro.org, mturquette@...libre.com, sboyd@...nel.org,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, kernel-team@...roid.com,
 tudor.ambarus@...aro.org, willmcvicker@...gle.com,
 semen.protsenko@...aro.org, alim.akhtar@...sung.com, s.nawrocki@...sung.com,
 tomasz.figa@...il.com, cw00.choi@...sung.com,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential
 clocks as critical

On 30/01/2024 10:36, André Draszik wrote:
> The peric0_top1_ipclk_0 and peric0_top1_pclk_0 are the clocks going to
> peric0/uart_usi, with pclk being the bus clock. Without pclk running,
> any bus access will hang.
> Unfortunately, in commit d97b6c902a40 ("arm64: dts: exynos: gs101:
> update USI UART to use peric0 clocks") the gs101 DT ended up specifying
> an incorrect pclk in the respective node and instead the two clocks
> here were marked as critical.
> 
> We have fixed the gs101 DT and can therefore drop this incorrect
> work-around here, the uart driver will claim these clocks as needed.

How did you fixed the DTS? Which commit did it? Are we going back to
basics of driver changes depending on DTS?

Best regards,
Krzysztof