linux-kernel - Re: [PATCH 6/6] wifi: cw1200: Convert to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6isv6wf.fsf@kernel.org>
Date: Thu, 01 Feb 2024 12:02:56 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Toke Høiland-Jørgensen <toke@...e.dk>,  Arend van
 Spriel
 <aspriel@...il.com>,  Franky Lin <franky.lin@...adcom.com>,  Hante
 Meuleman <hante.meuleman@...adcom.com>,  Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>,  Arnd Bergmann <arnd@...db.de>,  Lee
 Jones <lee@...nel.org>,  Brian Norris <briannorris@...omium.org>,
  Srinivasan Raju <srini.raju@...elifi.com>,
  linux-wireless@...r.kernel.org,  linux-kernel@...r.kernel.org,
  brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [PATCH 6/6] wifi: cw1200: Convert to GPIO descriptors

Linus Walleij <linus.walleij@...aro.org> writes:

> The CW1200 uses two GPIOs to control the powerup and reset
> pins, get these from GPIO descriptors instead of being passed
> as platform data from boardfiles.
>
> The RESET line will need to be marked as active low as we will
> let gpiolib handle the polarity inversion.
>
> The SDIO case is a bit special since the "card" need to be
> powered up before it gets detected on the SDIO bus and
> properly probed. Fix this by using board-specific GPIOs
> assigned to device "NULL".
>
> There are currently no in-tree users.
>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

[...]

> +/* Like the rest of the driver, this only supports one device per system */
> +static struct gpio_desc *cw1200_reset;
> +static struct gpio_desc *cw1200_powerup;

Side comment about cw1200 driver: it's pretty bad that the driver
supports only one device per system. As I haven't seen any real activity
for this driver a long time I thinking of just removing it in the near
future.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches