linux-kernel - Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240201-resupply-doorframe-feb41940155f-mkl@pengutronix.de>
Date: Thu, 1 Feb 2024 11:05:57 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: carlos.song@....com
Cc: broonie@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	kernel@...gutronix.de, linux-imx@....com, benjamin@...ler.one, stefanmoring@...il.com, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU
 mode

On 01.02.2024 18:01:15, carlos.song@....com wrote:
> From: Carlos Song <carlos.song@....com>
> 
> For DMA mode, the bus width of the DMA is equal to the size of data
> word, so burst length should be configured as bits per word.
> 
> For CPU mode, because of the spi transfer len is in byte, so burst
> length should be configured as bits per byte * spi_imx->count.
> 
> Signed-off-by: Carlos Song <carlos.song@....com>
> Reviewed-by: Clark Wang <xiaoning.wang@....com>
> Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length when using dma")
> Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead of assuming 8-bits")
> ---
> Changes for V3:
> - include <linux/bits.h> 
> ---
>  drivers/spi/spi-imx.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 546cdce525fc..2a1ae7b00760 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -21,7 +21,7 @@
>  #include <linux/types.h>
>  #include <linux/of.h>
>  #include <linux/property.h>
> -
> +#include <linux/bits.h>

nitpick:
Please keep the includes sorted alphabetically.

>  #include <linux/dma/imx-dma.h>

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |