[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<VI1PR04MB500557BCDB04B9385F20906BE8432@VI1PR04MB5005.eurprd04.prod.outlook.com>
Date: Thu, 1 Feb 2024 10:47:14 +0000
From: Carlos Song <carlos.song@....com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
CC: "broonie@...nel.org" <broonie@...nel.org>, "shawnguo@...nel.org"
<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>, dl-linux-imx
<linux-imx@....com>, "benjamin@...ler.one" <benjamin@...ler.one>,
"stefanmoring@...il.com" <stefanmoring@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-spi@...r.kernel.org"
<linux-spi@...r.kernel.org>
Subject: Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU
mode
> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: Thursday, February 1, 2024 6:06 PM
> To: Carlos Song <carlos.song@....com>
> Cc: broonie@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; dl-linux-imx <linux-imx@....com>; benjamin@...ler.one;
> stefanmoring@...il.com; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-spi@...r.kernel.org
> Subject: [EXT] Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU
> mode
>
> Caution: This is an external email. Please take care when clicking links or opening
> attachments. When in doubt, report the message using the 'Report this email'
> button
>
>
> On 01.02.2024 18:01:15, carlos.song@....com wrote:
> > From: Carlos Song <carlos.song@....com>
> >
> > For DMA mode, the bus width of the DMA is equal to the size of data
> > word, so burst length should be configured as bits per word.
> >
> > For CPU mode, because of the spi transfer len is in byte, so burst
> > length should be configured as bits per byte * spi_imx->count.
> >
> > Signed-off-by: Carlos Song <carlos.song@....com>
> > Reviewed-by: Clark Wang <xiaoning.wang@....com>
> > Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length
> > when using dma")
> > Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead
> > of assuming 8-bits")
> > ---
> > Changes for V3:
> > - include <linux/bits.h>
> > ---
> > drivers/spi/spi-imx.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> > 546cdce525fc..2a1ae7b00760 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -21,7 +21,7 @@
> > #include <linux/types.h>
> > #include <linux/of.h>
> > #include <linux/property.h>
> > -
> > +#include <linux/bits.h>
>
> nitpick:
> Please keep the includes sorted alphabetically.
>
> > #include <linux/dma/imx-dma.h>
>
Hi,
Hhh, thank you!
I will try my best to strictly adhere to the code format in the future!
This is a good habit and I couldn't agree more! V4 will be sent.
BR
Carlos
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux |
> https://www.pen/
> gutronix.de%2F&data=05%7C02%7Ccarlos.song%40nxp.com%7C53112bdae1e4
> 478f5fff08dc230d69fb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C638423787724098671%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&s
> data=33MzYSg%2Fq5ciMNGJmbrUcprP%2BH%2F%2FNl0IPNcUO%2BHoeF4%3D
> &reserved=0 |
> Vertretung Nürnberg | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Powered by blists - more mailing lists