linux-kernel - Re: [PATCH RFC 3/4] net: ethtool: Use uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zbual3uIsjXENw0c@nanopsycho>
Date: Thu, 1 Feb 2024 14:20:23 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: John Garry <john.g.garry@...cle.com>
Cc: Jakub Kicinski <kuba@...nel.org>, mcgrof@...nel.org,
	russ.weight@...ux.dev, gregkh@...uxfoundation.org,
	rafael@...nel.org, rostedt@...dmis.org, mhiramat@...nel.org,
	mathieu.desnoyers@...icios.com, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, keescook@...omium.org,
	masahiroy@...nel.org, nathan@...nel.org, nicolas@...sle.eu,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH RFC 3/4] net: ethtool: Use uts_release

Thu, Feb 01, 2024 at 01:57:16PM CET, john.g.garry@...cle.com wrote:
>On 31/01/2024 19:24, Jakub Kicinski wrote:
>> On Wed, 31 Jan 2024 10:48:50 +0000 John Garry wrote:
>> > Instead of using UTS_RELEASE, use uts_release, which means that we don't
>> > need to rebuild the code just for the git head commit changing.
>> > 
>> > Signed-off-by: John Garry<john.g.garry@...cle.com>
>> Yes, please!
>> 
>> Acked-by: Jakub Kicinski<kuba@...nel.org>
>
>Cheers
>
>BTW, I assume that changes like this are also ok:
>
>--------8<---------
>
>   net: team: Don't bother filling in ethtool driver version
>
>   The version is same as the default, as don't bother.
>
>   Signed-off-by: John Garry <john.g.garry@...cle.com>
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index f575f225d417..0a44bbdcfb7b 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -25,7 +25,6 @@
>#include <net/genetlink.h>
>#include <net/netlink.h>
>#include <net/sch_generic.h>
>-#include <generated/utsrelease.h>
>#include <linux/if_team.h>
>
>#define DRV_NAME "team"
>@@ -2074,7 +2073,6 @@ static void team_ethtool_get_drvinfo(struct
>net_device *dev,
>                                    struct ethtool_drvinfo *drvinfo)
>{
>       strscpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
>-       strscpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));

Yeah. I don't see why should anyone care about this "version"...
Let's remove it.

>}
>
>-------->8---------
>
>right?
>
>John
>
>
>
>
>